Commit ec8554b8 authored by Michael Straube's avatar Michael Straube Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: clean up comparsions to false 



Clean up comparsions to false.

x == false -> !x

Signed-off-by: default avatarMichael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210818080854.15847-2-straube.linux@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b3cab9a1

drivers/staging/r8188eu/core/rtw_cmd.c

+2 −2
Original line number Diff line number Diff line
@@ -1863,13 +1863,13 @@ static s32 c2h_evt_hdl(struct adapter *adapter, struct c2h_evt_hdr *c2h_evt, c2h 
		if (c2h_evt_read(adapter, buf) == _SUCCESS) {

			c2h_evt = (struct c2h_evt_hdr *)buf;



			if (filter && filter(c2h_evt->id) == false)

			if (filter && !filter(c2h_evt->id))

				goto exit;



			ret = rtw_hal_c2h_handler(adapter, c2h_evt);

		}

	} else {

		if (filter && filter(c2h_evt->id) == false)

		if (filter && !filter(c2h_evt->id))

			goto exit;



		ret = rtw_hal_c2h_handler(adapter, c2h_evt);

drivers/staging/r8188eu/core/rtw_ioctl_set.c

+1 −1
Original line number Diff line number Diff line
@@ -156,7 +156,7 @@ u8 rtw_set_802_11_bssid(struct adapter *padapter, u8 *bssid) 


	if (check_fwstate(pmlmepriv, _FW_LINKED | WIFI_ADHOC_MASTER_STATE)) {

		if (!memcmp(&pmlmepriv->cur_network.network.MacAddress, bssid, ETH_ALEN)) {

			if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) == false)

			if (!check_fwstate(pmlmepriv, WIFI_STATION_STATE))

				goto release_mlme_lock;/* it means driver is in WIFI_ADHOC_MASTER_STATE, we needn't create bss again. */

		} else {

			rtw_disassoc_cmd(padapter, 0, true);

drivers/staging/r8188eu/core/rtw_mlme.c

+6 −6
Original line number Diff line number Diff line
@@ -297,7 +297,7 @@ int rtw_if_up(struct adapter *padapter) 
	int res;



	if (padapter->bDriverStopped || padapter->bSurpriseRemoved ||

	    (check_fwstate(&padapter->mlmepriv, _FW_LINKED) == false))

	    !check_fwstate(&padapter->mlmepriv, _FW_LINKED))

		res = false;

	else

		res =  true;
@@ -708,7 +708,7 @@ void rtw_survey_event_callback(struct adapter *adapter, u8 *pbuf) 
	}



	/*  lock pmlmepriv->lock when you accessing network_q */

	if ((check_fwstate(pmlmepriv, _FW_UNDER_LINKING)) == false) {

	if (!check_fwstate(pmlmepriv, _FW_UNDER_LINKING)) {

		if (pnetwork->Ssid.Ssid[0] == 0)

			pnetwork->Ssid.SsidLength = 0;

		rtw_add_network(adapter, pnetwork);
@@ -748,7 +748,7 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf) 


	if (pmlmepriv->to_join) {

		if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) {

			if (check_fwstate(pmlmepriv, _FW_LINKED) == false) {

			if (!check_fwstate(pmlmepriv, _FW_LINKED)) {

				set_fwstate(pmlmepriv, _FW_UNDER_LINKING);



				if (rtw_select_and_join_from_scanned_queue(pmlmepriv) == _SUCCESS) {
@@ -1252,7 +1252,7 @@ void rtw_stassoc_event_callback(struct adapter *adapter, u8 *pbuf) 
	struct wlan_network	*cur_network = &pmlmepriv->cur_network;

	struct wlan_network	*ptarget_wlan = NULL;



	if (rtw_access_ctrl(adapter, pstassoc->macaddr) == false)

	if (!rtw_access_ctrl(adapter, pstassoc->macaddr))

		return;



#if defined(CONFIG_88EU_AP_MODE)
@@ -1542,12 +1542,12 @@ static int rtw_check_join_candidate(struct mlme_priv *pmlmepriv 
			goto exit;

	}



	if (rtw_is_desired_network(adapter, competitor)  == false)

	if (!rtw_is_desired_network(adapter, competitor))

		goto exit;



	if (rtw_to_roaming(adapter) > 0) {

		if (rtw_get_passing_time_ms((u32)competitor->last_scanned) >= RTW_SCAN_RESULT_EXPIRE ||

		    is_same_ess(&competitor->network, &pmlmepriv->cur_network.network) == false)

		    !is_same_ess(&competitor->network, &pmlmepriv->cur_network.network))

			goto exit;

	}

drivers/staging/r8188eu/core/rtw_mp.c

+2 −2
Original line number Diff line number Diff line
@@ -421,7 +421,7 @@ void mp_stop_test(struct adapter *padapter) 
	if (pmppriv->mode == MP_ON) {

		pmppriv->bSetTxPower = 0;

		spin_lock_bh(&pmlmepriv->lock);

		if (check_fwstate(pmlmepriv, WIFI_MP_STATE) == false)

		if (!check_fwstate(pmlmepriv, WIFI_MP_STATE))

			goto end_of_mp_stop_test;



		/* 3 1. disconnect psudo AdHoc */
@@ -866,7 +866,7 @@ u32 mp_query_psd(struct adapter *pAdapter, u8 *data) 
	if (!netif_running(pAdapter->pnetdev))

		return 0;



	if (check_fwstate(&pAdapter->mlmepriv, WIFI_MP_STATE) == false)

	if (!check_fwstate(&pAdapter->mlmepriv, WIFI_MP_STATE))

		return 0;



	if (strlen(data) == 0) { /* default value */

drivers/staging/r8188eu/core/rtw_pwrctrl.c

+7 −7
Original line number Diff line number Diff line
@@ -256,15 +256,15 @@ static u8 PS_RDY_CHECK(struct adapter *padapter) 
	if (delta_time < LPS_DELAY_TIME)

		return false;



	if ((check_fwstate(pmlmepriv, _FW_LINKED) == false) ||

	    (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY)) ||

	    (check_fwstate(pmlmepriv, WIFI_AP_STATE)) ||

	    (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) ||

	    (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)))

	if (!check_fwstate(pmlmepriv, _FW_LINKED) ||

	    check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) ||

	    check_fwstate(pmlmepriv, WIFI_AP_STATE) ||

	    check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) ||

	    check_fwstate(pmlmepriv, WIFI_ADHOC_STATE))

		return false;

	if (pwrpriv->bInSuspend)

		return false;

	if ((padapter->securitypriv.dot11AuthAlgrthm == dot11AuthAlgrthm_8021X) && (padapter->securitypriv.binstallGrpkey == false)) {

	if (padapter->securitypriv.dot11AuthAlgrthm == dot11AuthAlgrthm_8021X && !padapter->securitypriv.binstallGrpkey) {

		DBG_88E("Group handshake still in progress !!!\n");

		return false;

	}
@@ -365,7 +365,7 @@ void LPS_Enter(struct adapter *padapter) 
{

	struct pwrctrl_priv	*pwrpriv = &padapter->pwrctrlpriv;



	if (PS_RDY_CHECK(padapter) == false)

	if (!PS_RDY_CHECK(padapter))

		return;



	if (pwrpriv->bLeisurePs) {