Commit ec8401a4 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Marc Zyngier
Browse files

irqchip/gic-v3: Fix error handling in gic_populate_ppi_partitions 



of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
When kcalloc fails, it missing of_node_put() and results in refcount
leak. Fix this by goto out_put_node label.

Fixes: 52085d3f ("irqchip/gic-v3: Dynamically allocate PPI partition descriptors")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220601080930.31005-5-linmq006@gmail.com
parent 3d45670f

drivers/irqchip/irq-gic-v3.c

+1 −1
Original line number Diff line number Diff line
@@ -1932,7 +1932,7 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node) 


	gic_data.ppi_descs = kcalloc(gic_data.ppi_nr, sizeof(*gic_data.ppi_descs), GFP_KERNEL);

	if (!gic_data.ppi_descs)

		return;

		goto out_put_node;



	nr_parts = of_get_child_count(parts_node);