Commit ec7d6dd8 authored by YueHaibing's avatar YueHaibing Committed by David S. Miller
Browse files

ethernet: ucc_geth: Use kmemdup() rather than kmalloc+memcpy 



Issue identified with Coccinelle.

Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5d6c3d91

drivers/net/ethernet/freescale/ucc_geth.c

+1 −2
Original line number Diff line number Diff line
@@ -3590,10 +3590,9 @@ static int ucc_geth_probe(struct platform_device* ofdev) 
	if ((ucc_num < 0) || (ucc_num > 7))

		return -ENODEV;



	ug_info = kmalloc(sizeof(*ug_info), GFP_KERNEL);

	ug_info = kmemdup(&ugeth_primary_info, sizeof(*ug_info), GFP_KERNEL);

	if (ug_info == NULL)

		return -ENOMEM;

	memcpy(ug_info, &ugeth_primary_info, sizeof(*ug_info));



	ug_info->uf_info.ucc_num = ucc_num;