Commit ec475187 authored by Bard Liao's avatar Bard Liao Committed by Vinod Koul
Browse files

soundwire: bus: add more details to track failed transfers 



The current error log does not provide details on the type of
transfers and which address/count was requested. All this information
can help locate in which parts of the configuration process an error
occurred.

Co-developed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20210115053738.22630-4-yung-chuan.liao@linux.intel.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 6f206833

drivers/soundwire/bus.c

+4 −2
Original line number Diff line number Diff line
@@ -267,8 +267,10 @@ static int sdw_transfer_unlocked(struct sdw_bus *bus, struct sdw_msg *msg) 


	ret = do_transfer(bus, msg);

	if (ret != 0 && ret != -ENODATA)

		dev_err(bus->dev, "trf on Slave %d failed:%d\n",

			msg->dev_num, ret);

		dev_err(bus->dev, "trf on Slave %d failed:%d %s addr %x count %d\n",

			msg->dev_num, ret,

			(msg->flags & SDW_MSG_FLAG_WRITE) ? "write" : "read",

			msg->addr, msg->len);



	if (msg->page)

		sdw_reset_page(bus, msg->dev_num);