Commit ec0bb482 authored by Dan Carpenter's avatar Dan Carpenter Committed by Emil Velikov
Browse files

drm/gem: Fix a leak in drm_gem_objects_lookup() 



If the "handles" allocation or the copy_from_user() fails then we leak
"objs".  It's supposed to be freed in panfrost_job_cleanup().

Fixes: c117aa4d ("drm: Add a drm_gem_objects_lookup helper")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarEmil Velikov <emil.l.velikov@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200320132334.GC95012@mwanda
parent 5fa63f07

drivers/gpu/drm/drm_gem.c

+2 −2
Original line number Diff line number Diff line
@@ -709,6 +709,8 @@ int drm_gem_objects_lookup(struct drm_file *filp, void __user *bo_handles, 
	if (!objs)

		return -ENOMEM;



	*objs_out = objs;



	handles = kvmalloc_array(count, sizeof(u32), GFP_KERNEL);

	if (!handles) {

		ret = -ENOMEM;
@@ -722,8 +724,6 @@ int drm_gem_objects_lookup(struct drm_file *filp, void __user *bo_handles, 
	}



	ret = objects_lookup(filp, handles, count, objs);

	*objs_out = objs;



out:

	kvfree(handles);

	return ret;