Commit ebfe3e0c authored by Wenchao Hao's avatar Wenchao Hao Committed by Martin K. Petersen
Browse files

scsi: libiscsi: Remove unnecessary memset() in iscsi_conn_setup() 

iscsi_cls_conn is alloced by kzalloc(), the whole iscsi_cls_conn is zero
filled already including the dd_data. So it is unnecessary to call memset
again.

Link: https://lore.kernel.org/r/20220317150116.194140-1-haowenchao@huawei.com


Reviewed-by: default avatarWu Bo <wubo40@huawei.com>
Reviewed-by: default avatarLee Duncan <lduncan@suse.com>
Reviewed-by: default avatarMike Christie <michael.christie@oracle.com>
Signed-off-by: default avatarWenchao Hao <haowenchao@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 87d663d4

drivers/scsi/libiscsi.c

+0 −1
Original line number Diff line number Diff line
@@ -3045,7 +3045,6 @@ iscsi_conn_setup(struct iscsi_cls_session *cls_session, int dd_size, 
	if (!cls_conn)

		return NULL;

	conn = cls_conn->dd_data;

	memset(conn, 0, sizeof(*conn) + dd_size);



	conn->dd_data = cls_conn->dd_data + sizeof(*conn);

	conn->session = session;