Commit ebf04231 authored by Paul Blakey's avatar Paul Blakey Committed by Saeed Mahameed
Browse files

net/mlx5: CT: Remove extra rhashtable remove on tuple entries 



On tuple offload del command, tuples are tried to be removed twice
from the hashtable, once directly via mlx5_tc_ct_entry_remove_from_tuples()
and a second time in the following mlx5_tc_ct_entry_put()->
mlx5_tc_ct_entry_del()->mlx5_tc_ct_entry_remove_from_tuples() call.

This doesn't cause any issue since rhashtable first checks if the
removed object exists in the hashtable.

Remove the extra mlx5_tc_ct_entry_remove_from_tuples().

Signed-off-by: default avatarPaul Blakey <paulb@nvidia.com>
Reviewed-by: default avatarMaor Dickman <maord@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 0d7f1595

drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c

+0 −1
Original line number Diff line number Diff line
@@ -1161,7 +1161,6 @@ mlx5_tc_ct_block_flow_offload_del(struct mlx5_ct_ft *ft, 
	}



	rhashtable_remove_fast(&ft->ct_entries_ht, &entry->node, cts_ht_params);

	mlx5_tc_ct_entry_remove_from_tuples(entry);

	spin_unlock_bh(&ct_priv->ht_lock);



	mlx5_tc_ct_entry_put(entry);