Commit ebc002e3 authored by Alex Deucher's avatar Alex Deucher
Browse files

drm/amdgpu: don't use BACO for reset in S3 

Seems to cause a reboots or hangs on some systems.

Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1924
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1953


Fixes: daf8de08 ("drm/amdgpu: always reset the asic in suspend (v2)")
Reviewed-by: default avatarLijo Lazar <lijo.lazar@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
parent ca119884

drivers/gpu/drm/amd/pm/amdgpu_dpm.c

+11 −0
Original line number Diff line number Diff line
@@ -173,6 +173,17 @@ bool amdgpu_dpm_is_baco_supported(struct amdgpu_device *adev) 


	if (!pp_funcs || !pp_funcs->get_asic_baco_capability)

		return false;

	/* Don't use baco for reset in S3.

	 * This is a workaround for some platforms

	 * where entering BACO during suspend

	 * seems to cause reboots or hangs.

	 * This might be related to the fact that BACO controls

	 * power to the whole GPU including devices like audio and USB.

	 * Powering down/up everything may adversely affect these other

	 * devices.  Needs more investigation.

	 */

	if (adev->in_s3)

		return false;



	mutex_lock(&adev->pm.mutex);