Commit ebb2c96b authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

GenWQE: Ensure rc is not returning an uninitialized value 



rc is not initialized, so genwqe_finish_queue() either returns -EIO or
garbage.  Fortunately the return is not being checked by any callers,
so this has not yet caused any problems. Even so, it makes sense to
fix this small bug in case is is checked in future.

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarFrank Haverkamp <haver@linux.vnet.ibm.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 68fe8acc

drivers/misc/genwqe/card_ddcb.c

+1 −1
Original line number Diff line number Diff line
@@ -1310,7 +1310,7 @@ static int queue_wake_up_all(struct genwqe_dev *cd) 
 */

int genwqe_finish_queue(struct genwqe_dev *cd)

{

	int i, rc, in_flight;

	int i, rc = 0, in_flight;

	int waitmax = genwqe_ddcb_software_timeout;

	struct pci_dev *pci_dev = cd->pci_dev;

	struct ddcb_queue *queue = &cd->queue;