Commit eb85eec8 authored by Ohad Sharabi's avatar Ohad Sharabi Committed by Oded Gabbay
Browse files

habanalabs: fix possible memory leak in MMU DR fini 



This patch fixes what seems to be copy paste error.

We will have a memory leak if the host-resident shadow is NULL (which
will likely happen as the DR and HR are not dependent).

Signed-off-by: default avatarOhad Sharabi <osharabi@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent aff5d9d3

drivers/misc/habanalabs/common/mmu/mmu_v1.c

+1 −1
Original line number Diff line number Diff line
@@ -467,7 +467,7 @@ static void hl_mmu_v1_fini(struct hl_device *hdev) 
{

	/* MMU H/W fini was already done in device hw_fini() */



	if (!ZERO_OR_NULL_PTR(hdev->mmu_priv.hr.mmu_shadow_hop0)) {

	if (!ZERO_OR_NULL_PTR(hdev->mmu_priv.dr.mmu_shadow_hop0)) {

		kvfree(hdev->mmu_priv.dr.mmu_shadow_hop0);

		gen_pool_destroy(hdev->mmu_priv.dr.mmu_pgt_pool);