Unverified Commit eb7a7a93 authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!11737 hwmon: (adc128d818) Fix underflows seen when writing limit attributes 

Merge Pull Request from: @ci-robot 
 
PR sync from: Chen Zhongjin <chenzhongjin@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/66RHGES7EYGWLKAIIXBVDZO37KTA4G25/ 
 
https://gitee.com/src-openeuler/kernel/issues/IARWHX 
 
Link:https://gitee.com/openeuler/kernel/pulls/11737

 

Reviewed-by: default avatarYe Weihua <yeweihua4@huawei.com>
Reviewed-by: default avatarXu Kuohai <xukuohai@huawei.com>
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
parents 95739c2a b9ab42b2

drivers/hwmon/adc128d818.c

+2 −2
Original line number Diff line number Diff line
@@ -184,7 +184,7 @@ static ssize_t adc128_set_in(struct device *dev, struct device_attribute *attr, 


	mutex_lock(&data->update_lock);

	/* 10 mV LSB on limit registers */

	regval = clamp_val(DIV_ROUND_CLOSEST(val, 10), 0, 255);

	regval = DIV_ROUND_CLOSEST(clamp_val(val, 0, 2550), 10);

	data->in[index][nr] = regval << 4;

	reg = index == 1 ? ADC128_REG_IN_MIN(nr) : ADC128_REG_IN_MAX(nr);

	i2c_smbus_write_byte_data(data->client, reg, regval);
@@ -222,7 +222,7 @@ static ssize_t adc128_set_temp(struct device *dev, 
		return err;



	mutex_lock(&data->update_lock);

	regval = clamp_val(DIV_ROUND_CLOSEST(val, 1000), -128, 127);

	regval = DIV_ROUND_CLOSEST(clamp_val(val, -128000, 127000), 1000);

	data->temp[index] = regval << 1;

	i2c_smbus_write_byte_data(data->client,

				  index == 1 ? ADC128_REG_TEMP_MAX