Commit ead9a76c authored by David S. Miller's avatar David S. Miller
Browse files

macvlan: Stop using NLA_PUT*(). 



These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1a106de6

drivers/net/macvlan.c

+2 −1
Original line number Diff line number Diff line
@@ -773,7 +773,8 @@ static int macvlan_fill_info(struct sk_buff *skb, 
{

	struct macvlan_dev *vlan = netdev_priv(dev);



	NLA_PUT_U32(skb, IFLA_MACVLAN_MODE, vlan->mode);

	if (nla_put_u32(skb, IFLA_MACVLAN_MODE, vlan->mode))

		goto nla_put_failure;

	return 0;



nla_put_failure: