Commit eac67d83 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

wwan: iosm: use a flexible array rather than allocate short objects 



GCC array-bounds warns that ipc_coredump_get_list() under-allocates
the size of struct iosm_cd_table *cd_table.

This is avoidable - we just need a flexible array. Nothing calls
sizeof() on struct iosm_cd_list or anything that contains it.

Reviewed-by: default avatarM Chetan Kumar <m.chetan.kumar@intel.com>
Link: https://lore.kernel.org/r/20220520060013.2309497-1-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 29849a48

drivers/net/wwan/iosm/iosm_ipc_coredump.h

+1 −4
Original line number Diff line number Diff line
@@ -14,9 +14,6 @@ 
/* Max buffer allocated to receive coredump data */

#define MAX_DATA_SIZE 0x00010000



/* Max number of file entries */

#define MAX_NOF_ENTRY 256



/* Max length */

#define MAX_SIZE_LEN 32
@@ -38,7 +35,7 @@ struct iosm_cd_list_entry { 
 */

struct iosm_cd_list {

	__le32 num_entries;

	struct iosm_cd_list_entry entry[MAX_NOF_ENTRY];

	struct iosm_cd_list_entry entry[];

} __packed;



/**