Commit ea9bc8b9 authored by Shashank Sharma's avatar Shashank Sharma Committed by Alex Deucher
Browse files

drm/amdgpu/dm: Fix NULL pointer crash during DP MST hotplug 



This patch checks the return value of the function
dc_link_add_remote_sink before using it. This was causing
a crash during consecutive hotplugs of DP MST displays.

Cc: Harry Wentland <harry.wentland@amd.com>
Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarShashank Sharma <shashank.sharma@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent fe180178

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c

+5 −0
Original line number Original line Diff line number Diff line
@@ -229,6 +229,11 @@ static int dm_dp_mst_get_modes(struct drm_connector *connector) 
			(aconnector->edid->extensions + 1) * EDID_LENGTH,

			(aconnector->edid->extensions + 1) * EDID_LENGTH,

			&init_params);

			&init_params);





		if (!dc_sink) {

			DRM_ERROR("Unable to add a remote sink\n");

			return 0;

		}



		dc_sink->priv = aconnector;

		dc_sink->priv = aconnector;

		/* dc_link_add_remote_sink returns a new reference */

		/* dc_link_add_remote_sink returns a new reference */

		aconnector->dc_sink = dc_sink;

		aconnector->dc_sink = dc_sink;