Commit ea852c17 authored by Gerhard Engleder's avatar Gerhard Engleder Committed by David S. Miller
Browse files

tsnep: Fix NAPI scheduling 



According to the NAPI documentation networking/napi.rst, drivers which
have to mask interrupts explicitly should use the napi_schedule_prep()
and __napi_schedule() calls.

No problem seen so far with current implementation. Nevertheless, let's
align the implementation with documentation.

Signed-off-by: default avatarGerhard Engleder <gerhard@engleder-embedded.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent af21b94b

drivers/net/ethernet/engleder/tsnep_main.c

+10 −4
Original line number Diff line number Diff line
@@ -87,8 +87,11 @@ static irqreturn_t tsnep_irq(int irq, void *arg) 


	/* handle TX/RX queue 0 interrupt */

	if ((active & adapter->queue[0].irq_mask) != 0) {

		if (napi_schedule_prep(&adapter->queue[0].napi)) {

			tsnep_disable_irq(adapter, adapter->queue[0].irq_mask);

		napi_schedule(&adapter->queue[0].napi);

			/* schedule after masking to avoid races */

			__napi_schedule(&adapter->queue[0].napi);

		}

	}



	return IRQ_HANDLED;
@@ -99,8 +102,11 @@ static irqreturn_t tsnep_irq_txrx(int irq, void *arg) 
	struct tsnep_queue *queue = arg;



	/* handle TX/RX queue interrupt */

	if (napi_schedule_prep(&queue->napi)) {

		tsnep_disable_irq(queue->adapter, queue->irq_mask);

	napi_schedule(&queue->napi);

		/* schedule after masking to avoid races */

		__napi_schedule(&queue->napi);

	}



	return IRQ_HANDLED;

}