Unverified Commit ea4ab99c authored by Matija Glavinic Pecotic's avatar Matija Glavinic Pecotic Committed by Mark Brown
Browse files

spi: davinci: invoke chipselect callback 



Davinci needs to configure chipselect on transfer.

Fixes: 4a07b8bc ("spi: bitbang: Make chipselect callback optional")
Signed-off-by: default avatarMatija Glavinic Pecotic <matija.glavinic-pecotic.ext@nokia.com>
Reviewed-by: default avatarAlexander Sverdlin <alexander.sverdlin@nokia.com>
Link: https://lore.kernel.org/r/735fb7b0-82aa-5b9b-85e4-53f0c348cc0e@nokia.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent d68f4c73

drivers/spi/spi-davinci.c

+1 −7
Original line number Diff line number Diff line
@@ -213,12 +213,6 @@ static void davinci_spi_chipselect(struct spi_device *spi, int value) 
	 * line for the controller

	 */

	if (spi->cs_gpiod) {

		/*

		 * FIXME: is this code ever executed? This host does not

		 * set SPI_MASTER_GPIO_SS so this chipselect callback should

		 * not get called from the SPI core when we are using

		 * GPIOs for chip select.

		 */

		if (value == BITBANG_CS_ACTIVE)

			gpiod_set_value(spi->cs_gpiod, 1);

		else
@@ -945,7 +939,7 @@ static int davinci_spi_probe(struct platform_device *pdev) 
	master->bus_num = pdev->id;

	master->num_chipselect = pdata->num_chipselect;

	master->bits_per_word_mask = SPI_BPW_RANGE_MASK(2, 16);

	master->flags = SPI_MASTER_MUST_RX;

	master->flags = SPI_MASTER_MUST_RX | SPI_MASTER_GPIO_SS;

	master->setup = davinci_spi_setup;

	master->cleanup = davinci_spi_cleanup;

	master->can_dma = davinci_spi_can_dma;