Commit ea32af47 authored by Filipe Manana's avatar Filipe Manana Committed by David Sterba
Browse files

btrfs: zoned: fix wrong mutex unlock on failure to allocate log root tree 



When syncing the log, if we fail to allocate the root node for the log
root tree:

1) We are unlocking fs_info->tree_log_mutex, but at this point we have
   not yet locked this mutex;

2) We have locked fs_info->tree_root->log_mutex, but we end up not
   unlocking it;

So fix this by unlocking fs_info->tree_root->log_mutex instead of
fs_info->tree_log_mutex.

Fixes: e75f9fd1 ("btrfs: zoned: move log tree node allocation out of log_root_tree->log_mutex")
CC: stable@vger.kernel.org # 5.13+
Reviewed-by: default avatarNikolay Borisov <nborisov@suse.com>
Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 9cc0b837

fs/btrfs/tree-log.c

+1 −1
Original line number Diff line number Diff line
@@ -3173,7 +3173,7 @@ int btrfs_sync_log(struct btrfs_trans_handle *trans, 
		if (!log_root_tree->node) {

			ret = btrfs_alloc_log_tree_node(trans, log_root_tree);

			if (ret) {

				mutex_unlock(&fs_info->tree_log_mutex);

				mutex_unlock(&fs_info->tree_root->log_mutex);

				goto out;

			}

		}