Commit ea2949df authored by Biju Das's avatar Biju Das Committed by Wim Van Sebroeck
Browse files

watchdog: rzg2l_wdt: Fix 32bit overflow issue 



The value of timer_cycle_us can be 0 due to 32bit overflow.
For eg:- If we assign the counter value "0xfff" for computing
maxval.

This patch fixes this issue by appending ULL to 1024, so that
it is promoted to 64bit.

This patch also fixes the warning message, 'watchdog: Invalid min and
max timeout values, resetting to 0!'.

Fixes: 2cbc5cd0 ("watchdog: Add Watchdog Timer driver for RZ/G2L")
Signed-off-by: default avatarBiju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20220225175320.11041-2-biju.das.jz@bp.renesas.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@linux-watchdog.org>
parent 289660a4

drivers/watchdog/rzg2l_wdt.c

+1 −1
Original line number Diff line number Diff line
@@ -53,7 +53,7 @@ static void rzg2l_wdt_wait_delay(struct rzg2l_wdt_priv *priv) 


static u32 rzg2l_wdt_get_cycle_usec(unsigned long cycle, u32 wdttime)

{

	u64 timer_cycle_us = 1024 * 1024 * (wdttime + 1) * MICRO;

	u64 timer_cycle_us = 1024 * 1024ULL * (wdttime + 1) * MICRO;



	return div64_ul(timer_cycle_us, cycle);

}