Commit ea15e8db authored by Zenghui Yu's avatar Zenghui Yu Committed by Yuntao Liu
Browse files

irqchip/alpine-msi: Fix off-by-one in allocation error path 

stable inclusion
from stable-v5.10.219
commit f31b49ba366260ef7a1af537f936b3837359fe04
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IAMQU1

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=f31b49ba366260ef7a1af537f936b3837359fe04



--------------------------------

[ Upstream commit ff3669a71afa06208de58d6bea1cc49d5e3fcbd1 ]

When alpine_msix_gic_domain_alloc() fails, there is an off-by-one in the
number of interrupts to be freed.

Fix it by passing the number of successfully allocated interrupts, instead
of the relative index of the last allocated one.

Fixes: 3841245e ("irqchip/alpine-msi: Fix freeing of interrupts on allocation error path")
Signed-off-by: default avatarZenghui Yu <yuzenghui@huawei.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20240327142305.1048-1-yuzenghui@huawei.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Conflicts:
	drivers/irqchip/irq-alpine-msi.c
[adjust context]
Signed-off-by: default avatarYuntao Liu <liuyuntao12@huawei.com>
parent 4ac8b0d8

drivers/irqchip/irq-alpine-msi.c

+1 −2
Original line number Diff line number Diff line
@@ -165,7 +165,6 @@ static int alpine_msix_middle_domain_alloc(struct irq_domain *domain, 
	return 0;



err_sgi:

	while (--i >= 0)

	irq_domain_free_irqs_parent(domain, virq, i);

	alpine_msix_free_sgi(priv, sgi, nr_irqs);

	return err;