Commit ea07af2e authored by Stéphane Graber's avatar Stéphane Graber Committed by Jakub Kicinski
Browse files

openvswitch: Add recirc_id to recirc warning 



When hitting the recirculation limit, the kernel would currently log
something like this:

[   58.586597] openvswitch: ovs-system: deferred action limit reached, drop recirc action

Which isn't all that useful to debug as we only have the interface name
to go on but can't track it down to a specific flow.

With this change, we now instead get:

[   58.586597] openvswitch: ovs-system: deferred action limit reached, drop recirc action (recirc_id=0x9e)

Which can now be correlated with the flow entries from OVS.

Suggested-by: default avatarFrode Nordahl <frode.nordahl@canonical.com>
Signed-off-by: default avatarStéphane Graber <stgraber@ubuntu.com>
Tested-by: default avatarStephane Graber <stgraber@ubuntu.com>
Acked-by: default avatarEelco Chaudron <echaudro@redhat.com>
Link: https://lore.kernel.org/r/20220330194244.3476544-1-stgraber@ubuntu.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 46b55620

net/openvswitch/actions.c

+2 −2
Original line number Diff line number Diff line
@@ -1539,8 +1539,8 @@ static int clone_execute(struct datapath *dp, struct sk_buff *skb, 
				pr_warn("%s: deferred action limit reached, drop sample action\n",

					ovs_dp_name(dp));

			} else {  /* Recirc action */

				pr_warn("%s: deferred action limit reached, drop recirc action\n",

					ovs_dp_name(dp));

				pr_warn("%s: deferred action limit reached, drop recirc action (recirc_id=%#x)\n",

					ovs_dp_name(dp), recirc_id);

			}

		}

	}