Commit e9ca70c7 authored by Yang Li's avatar Yang Li Committed by Kalle Valo
Browse files

ath10k: Fix an error code in ath10k_add_interface() 



When the code execute this if statement, the value of ret is 0.
However, we can see from the ath10k_warn() log that the value of
ret should be -EINVAL.

Clean up smatch warning:

drivers/net/wireless/ath/ath10k/mac.c:5596 ath10k_add_interface() warn:
missing error code 'ret'

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Fixes: ccec9038 ("ath10k: enable raw encap mode and software crypto engine")
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1621939577-62218-1-git-send-email-yang.lee@linux.alibaba.com
parent 515bda1d

drivers/net/wireless/ath/ath10k/mac.c

+1 −0
Original line number Diff line number Diff line
@@ -5592,6 +5592,7 @@ static int ath10k_add_interface(struct ieee80211_hw *hw, 


	if (arvif->nohwcrypt &&

	    !test_bit(ATH10K_FLAG_RAW_MODE, &ar->dev_flags)) {

		ret = -EINVAL;

		ath10k_warn(ar, "cryptmode module param needed for sw crypto\n");

		goto err;

	}