Commit e9b57aaa authored by Jeffle Xu's avatar Jeffle Xu Committed by David Howells
Browse files

fscache: export fscache_end_operation() 



Export fscache_end_operation() to avoid code duplication.

Besides, considering the paired fscache_begin_read_operation() is
already exported, it shall make sense to also export
fscache_end_operation().

Signed-off-by: default avatarJeffle Xu <jefflexu@linux.alibaba.com>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
cc: linux-cachefs@redhat.com

Link: https://lore.kernel.org/r/20220302125134.131039-2-jefflexu@linux.alibaba.com/ # Jeffle's v4
Link: https://lore.kernel.org/r/164622971432.3564931.12184135678781328146.stgit@warthog.procyon.org.uk/ # v1
Link: https://lore.kernel.org/r/164678190346.1200972.7453733431978569479.stgit@warthog.procyon.org.uk/ # v2
Link: https://lore.kernel.org/r/164692888334.2099075.5166283293894267365.stgit@warthog.procyon.org.uk/ # v3
Link: https://lore.kernel.org/r/20220316131723.111553-2-jefflexu@linux.alibaba.com/ # v5
parent ad5255c1

fs/cifs/fscache.c

+0 −8
Original line number Diff line number Diff line
@@ -134,14 +134,6 @@ void cifs_fscache_release_inode_cookie(struct inode *inode) 
	}

}



static inline void fscache_end_operation(struct netfs_cache_resources *cres)

{

	const struct netfs_cache_ops *ops = fscache_operation_valid(cres);



	if (ops)

		ops->end_operation(cres);

}



/*

 * Fallback page reading interface.

 */

fs/fscache/internal.h

+0 −11
Original line number Diff line number Diff line
@@ -70,17 +70,6 @@ static inline void fscache_see_cookie(struct fscache_cookie *cookie, 
			     where);

}



/*

 * io.c

 */

static inline void fscache_end_operation(struct netfs_cache_resources *cres)

{

	const struct netfs_cache_ops *ops = fscache_operation_valid(cres);



	if (ops)

		ops->end_operation(cres);

}



/*

 * main.c

 */

fs/nfs/fscache.c

+0 −8
Original line number Diff line number Diff line
@@ -249,14 +249,6 @@ void nfs_fscache_release_file(struct inode *inode, struct file *filp) 
	}

}



static inline void fscache_end_operation(struct netfs_cache_resources *cres)

{

	const struct netfs_cache_ops *ops = fscache_operation_valid(cres);



	if (ops)

		ops->end_operation(cres);

}



/*

 * Fallback page reading interface.

 */

include/linux/fscache.h

+14 −0
Original line number Diff line number Diff line
@@ -456,6 +456,20 @@ int fscache_begin_read_operation(struct netfs_cache_resources *cres, 
	return -ENOBUFS;

}



/**

 * fscache_end_operation - End the read operation for the netfs lib

 * @cres: The cache resources for the read operation

 *

 * Clean up the resources at the end of the read request.

 */

static inline void fscache_end_operation(struct netfs_cache_resources *cres)

{

	const struct netfs_cache_ops *ops = fscache_operation_valid(cres);



	if (ops)

		ops->end_operation(cres);

}



/**

 * fscache_read - Start a read from the cache.

 * @cres: The cache resources to use