Commit e9afd457 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Rob Clark
Browse files

drm/msm/dpu: Remove commit and its uses in dpu_crtc_set_crc_source() 

Clang warns:

drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:162:6: error: variable 'commit' is uninitialized when used here [-Werror,-Wuninitialized]
        if (commit)
            ^~~~~~
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:106:32: note: initialize the variable 'commit' to silence this warning
        struct drm_crtc_commit *commit;
                                      ^
                                       = NULL
1 error generated.

The assignment and use of commit in the main body of
dpu_crtc_set_crc_source() were removed from v1 to v2 but the call to
drm_crtc_commit_put() at the end was not. Do that now so there is no
more warning.

Fixes: 78d9b458 ("drm/msm/dpu: Add CRC support for DPU")
Link: https://github.com/ClangBuiltLinux/linux/issues/1493


Reported-by: default avatar"kernelci.org bot" <bot@kernelci.org>
Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20211026142435.3606413-1-nathan@kernel.org


Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
parent 00326bfa

drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c

+0 −3
Original line number Diff line number Diff line
@@ -103,7 +103,6 @@ static int dpu_crtc_set_crc_source(struct drm_crtc *crtc, const char *src_name) 
{

	enum dpu_crtc_crc_source source = dpu_crtc_parse_crc_source(src_name);

	enum dpu_crtc_crc_source current_source;

	struct drm_crtc_commit *commit;

	struct dpu_crtc_state *crtc_state;

	struct drm_device *drm_dev = crtc->dev;

	struct dpu_crtc_mixer *m;
@@ -159,8 +158,6 @@ static int dpu_crtc_set_crc_source(struct drm_crtc *crtc, const char *src_name) 




cleanup:

	if (commit)

		drm_crtc_commit_put(commit);

	drm_modeset_unlock(&crtc->mutex);



	return ret;