Commit e9aeabae authored by Johannes Berg's avatar Johannes Berg Committed by John W. Linville
Browse files

mac80211: validate SIOCSIWPOWER arguments better 



Don't accept any arguments we don't handle, and return error codes
instead of using an uninitialised stack value.

Signed-off-by: default avatarJohannes Berg <johannes@sipsolutions.net>
Reviewed-by: default avatarKalle Valo <kalle.valo@nokia.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 4797938c

net/mac80211/wext.c

+4 −1
Original line number Diff line number Diff line
@@ -853,9 +853,12 @@ static int ieee80211_ioctl_siwpower(struct net_device *dev, 
		ps = true;

		break;

	default:                /* Otherwise we ignore */

		break;

		return -EINVAL;

	}



	if (wrq->flags & ~(IW_POWER_MODE | IW_POWER_TIMEOUT))

		return -EINVAL;



	if (wrq->flags & IW_POWER_TIMEOUT)

		timeout = wrq->value / 1000;