Commit e9a40e15 authored by Kees Cook's avatar Kees Cook
Browse files

fortify: Do not cast to "unsigned char" 

Do not cast to "unsigned char", as this needlessly creates type problems
when attempting builds without -Wno-pointer-sign[1]. The intent of the
cast is to drop possible "const" types.

[1] https://lore.kernel.org/lkml/CAHk-=wgz3Uba8w7kdXhsqR1qvfemYL+OFQdefJnkeqXG8qZ_pA@mail.gmail.com/



Suggested-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Fixes: 3009f891 ("fortify: Allow strlen() and strnlen() to pass compile-time known lengths")
Cc: linux-hardening@vger.kernel.org
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
parent fb3d88ab

include/linux/fortify-string.h

+1 −1
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ void __write_overflow_field(size_t avail, size_t wanted) __compiletime_warning(" 


#define __compiletime_strlen(p)					\

({								\

	unsigned char *__p = (unsigned char *)(p);		\

	char *__p = (char *)(p);				\

	size_t __ret = SIZE_MAX;				\

	size_t __p_size = __member_size(p);			\

	if (__p_size != SIZE_MAX &&				\