Commit e98365af authored by Jian Shen's avatar Jian Shen Committed by David S. Miller
Browse files

net: hns3: clear inited state and stop client after failed to register netdev 



If failed to register netdev, it needs to clear INITED state and stop
client in case of cause problem when concurrency with uninitialized
process of driver.

Fixes: a289a7e5 ("net: hns3: put off calling register_netdev() until client initialize complete")
Signed-off-by: default avatarJian Shen <shenjian15@huawei.com>
Signed-off-by: default avatarGuangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5220a525

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+9 −0
Original line number Diff line number Diff line
@@ -5203,6 +5203,13 @@ static void hns3_state_init(struct hnae3_handle *handle) 
		set_bit(HNS3_NIC_STATE_RXD_ADV_LAYOUT_ENABLE, &priv->state);

}



static void hns3_state_uninit(struct hnae3_handle *handle)

{

	struct hns3_nic_priv *priv  = handle->priv;



	clear_bit(HNS3_NIC_STATE_INITED, &priv->state);

}



static int hns3_client_init(struct hnae3_handle *handle)

{

	struct pci_dev *pdev = handle->pdev;
@@ -5320,7 +5327,9 @@ static int hns3_client_init(struct hnae3_handle *handle) 
	return ret;



out_reg_netdev_fail:

	hns3_state_uninit(handle);

	hns3_dbg_uninit(handle);

	hns3_client_stop(handle);

out_client_start:

	hns3_free_rx_cpu_rmap(netdev);

	hns3_nic_uninit_irq(priv);