Unverified Commit e9800482 authored by Muhammad Usama Anjum's avatar Muhammad Usama Anjum Committed by Mark Brown
Browse files

spi: orion: set devdata properly as it is being used later 



If device_get_match_data returns NULL, devdata isn't being updated
properly. It is being used later in the function. Both devdata and
spi->devdata should be updated to avoid NULL pointer dereference.

Addresses-Coverity: ("NULL pointer dereference")
Fixes: 0e6521f1 ("spi: orion: Use device_get_match_data() helper")
Signed-off-by: default avatarMuhammad Usama Anjum <musamaanjum@gmail.com>
Link: https://lore.kernel.org/r/20210408195718.GA3075166@LEGION


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4df2f5e1

drivers/spi/spi-orion.c

+2 −1
Original line number Diff line number Diff line
@@ -676,7 +676,8 @@ static int orion_spi_probe(struct platform_device *pdev) 
	spi->dev = &pdev->dev;



	devdata = device_get_match_data(&pdev->dev);

	spi->devdata = devdata ? devdata : &orion_spi_dev_data;

	devdata = devdata ? devdata : &orion_spi_dev_data;

	spi->devdata = devdata;



	spi->clk = devm_clk_get(&pdev->dev, NULL);

	if (IS_ERR(spi->clk)) {