Commit e963a19c authored by Bitterblue Smith's avatar Bitterblue Smith Committed by Kalle Valo
Browse files

wifi: rtl8xxxu: gen2: Fix mistake in path B IQ calibration 



Found by comparing with the vendor driver. Currently this affects
only the RTL8192EU, which is the only gen2 chip with 2 TX paths
supported by this driver. It's unclear what kind of effect the
mistake had in practice, since I don't have any RTL8192EU devices
to test it.

Fixes: e1547c53 ("rtl8xxxu: First stab at adding IQK calibration for 8723bu parts")
Signed-off-by: default avatarBitterblue Smith <rtl8821cerfe2@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/30a59f3a-cfa9-8379-7af0-78a8f4c77cfd@gmail.com
parent bd1056d4

drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c

+2 −2
Original line number Diff line number Diff line
@@ -2929,12 +2929,12 @@ bool rtl8xxxu_gen2_simularity_compare(struct rtl8xxxu_priv *priv, 
		}



		if (!(simubitmap & 0x30) && priv->tx_paths > 1) {

			/* path B RX OK */

			/* path B TX OK */

			for (i = 4; i < 6; i++)

				result[3][i] = result[c1][i];

		}



		if (!(simubitmap & 0x30) && priv->tx_paths > 1) {

		if (!(simubitmap & 0xc0) && priv->tx_paths > 1) {

			/* path B RX OK */

			for (i = 6; i < 8; i++)

				result[3][i] = result[c1][i];