Commit e9538f82 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by David S. Miller
Browse files

devlink: Remove misleading internal_flags from health reporter dump 



DEVLINK_CMD_HEALTH_REPORTER_DUMP_GET command doesn't have .doit callback
and has no use in internal_flags at all. Remove this misleading assignment.

Fixes: e44ef4e4 ("devlink: Hang reporter's dump method on a dumpit cb")
Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a4920d5d

net/core/devlink.c

+0 −2
Original line number Diff line number Diff line
@@ -8845,8 +8845,6 @@ static const struct genl_small_ops devlink_nl_ops[] = { 
			    GENL_DONT_VALIDATE_DUMP_STRICT,

		.dumpit = devlink_nl_cmd_health_reporter_dump_get_dumpit,

		.flags = GENL_ADMIN_PERM,

		.internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK_OR_PORT |

				  DEVLINK_NL_FLAG_NO_LOCK,

	},

	{

		.cmd = DEVLINK_CMD_HEALTH_REPORTER_DUMP_CLEAR,