Commit e93c7d8e authored by Shiraz Saleem's avatar Shiraz Saleem Committed by Jason Gunthorpe
Browse files

RDMA/irdma: Process extended CQ entries correctly 

The valid bit for extended CQE's written by HW is retrieved from the
incorrect quad-word. This leads to missed completions for any UD traffic
particularly after a wrap-around.

Get the valid bit for extended CQE's from the correct quad-word in the
descriptor.

Fixes: 551c46ed ("RDMA/irdma: Add user/kernel shared libraries")
Link: https://lore.kernel.org/r/20211005182302.374-1-shiraz.saleem@intel.com


Signed-off-by: default avatarShiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 9e1ff307

drivers/infiniband/hw/irdma/uk.c

+2 −2
Original line number Diff line number Diff line
@@ -1092,12 +1092,12 @@ irdma_uk_cq_poll_cmpl(struct irdma_cq_uk *cq, struct irdma_cq_poll_info *info) 
		if (cq->avoid_mem_cflct) {

			ext_cqe = (__le64 *)((u8 *)cqe + 32);

			get_64bit_val(ext_cqe, 24, &qword7);

			polarity = (u8)FIELD_GET(IRDMA_CQ_VALID, qword3);

			polarity = (u8)FIELD_GET(IRDMA_CQ_VALID, qword7);

		} else {

			peek_head = (cq->cq_ring.head + 1) % cq->cq_ring.size;

			ext_cqe = cq->cq_base[peek_head].buf;

			get_64bit_val(ext_cqe, 24, &qword7);

			polarity = (u8)FIELD_GET(IRDMA_CQ_VALID, qword3);

			polarity = (u8)FIELD_GET(IRDMA_CQ_VALID, qword7);

			if (!peek_head)

				polarity ^= 1;

		}