Unverified Commit e937440f authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Mark Brown
Browse files

spi: meson-spicc: add IRQ check in meson_spicc_probe 



This check misses checking for  platform_get_irq()'s call and may passes
the negative error codes to devm_request_irq(), which takes unsigned IRQ #,
causing it to fail with -EINVAL, overriding an original error code.
Stop calling devm_request_irq() with invalid IRQ #s.

Fixes: 454fa271 ("spi: Add Meson SPICC driver")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220126110447.24549-1-linmq006@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 23e3404d

drivers/spi/spi-meson-spicc.c

+5 −0
Original line number Diff line number Diff line
@@ -693,6 +693,11 @@ static int meson_spicc_probe(struct platform_device *pdev) 
	writel_relaxed(0, spicc->base + SPICC_INTREG);



	irq = platform_get_irq(pdev, 0);

	if (irq < 0) {

		ret = irq;

		goto out_master;

	}



	ret = devm_request_irq(&pdev->dev, irq, meson_spicc_irq,

			       0, NULL, spicc);

	if (ret) {