Commit e8fbe99e authored by Ben Greear's avatar Ben Greear Committed by Johannes Berg
Browse files

wifi: iwlwifi: Ensure ack flag is properly cleared. 



Debugging indicates that nothing else is clearing the info->flags,
so some frames were flagged as ACKed when they should not be.
Explicitly clear the ack flag to ensure this does not happen.

Signed-off-by: default avatarBen Greear <greearb@candelatech.com>
Acked-by: default avatarGregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230808205605.4105670-1-greearb@candelatech.com


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 424c82e8

drivers/net/wireless/intel/iwlwifi/mvm/tx.c

+3 −0
Original line number Diff line number Diff line
@@ -1612,6 +1612,7 @@ static void iwl_mvm_rx_tx_cmd_single(struct iwl_mvm *mvm, 
		iwl_trans_free_tx_cmd(mvm->trans, info->driver_data[1]);



		memset(&info->status, 0, sizeof(info->status));

		info->flags &= ~(IEEE80211_TX_STAT_ACK | IEEE80211_TX_STAT_TX_FILTERED);



		/* inform mac80211 about what happened with the frame */

		switch (status & TX_STATUS_MSK) {
@@ -1964,6 +1965,8 @@ static void iwl_mvm_tx_reclaim(struct iwl_mvm *mvm, int sta_id, int tid, 
		 */

		if (!is_flush)

			info->flags |= IEEE80211_TX_STAT_ACK;

		else

			info->flags &= ~IEEE80211_TX_STAT_ACK;

	}



	/*