Commit e8b1d769 authored by José Expósito's avatar José Expósito Committed by Jakub Kicinski
Browse files

net: dsa: felix: Fix memory leak in felix_setup_mmio_filtering 



Avoid a memory leak if there is not a CPU port defined.

Fixes: 8d5f7954 ("net: dsa: felix: break at first CPU port during init and teardown")
Addresses-Coverity-ID: 1492897 ("Resource leak")
Addresses-Coverity-ID: 1492899 ("Resource leak")
Signed-off-by: default avatarJosé Expósito <jose.exposito89@gmail.com>
Reviewed-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20211209110538.11585-1-jose.exposito89@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 37ad4e2a

drivers/net/dsa/ocelot/felix.c

+4 −1
Original line number Diff line number Diff line
@@ -290,8 +290,11 @@ static int felix_setup_mmio_filtering(struct felix *felix) 
		}

	}



	if (cpu < 0)

	if (cpu < 0) {

		kfree(tagging_rule);

		kfree(redirect_rule);

		return -EINVAL;

	}



	tagging_rule->key_type = OCELOT_VCAP_KEY_ETYPE;

	*(__be16 *)tagging_rule->key.etype.etype.value = htons(ETH_P_1588);