Commit e8ae0e14 authored by Jason Gunthorpe's avatar Jason Gunthorpe Committed by Joerg Roedel
Browse files

vfio: Require that devices support DMA cache coherence 



IOMMU_CACHE means that normal DMAs do not require any additional coherency
mechanism and is the basic uAPI that VFIO exposes to userspace. For
instance VFIO applications like DPDK will not work if additional coherency
operations are required.

Therefore check IOMMU_CAP_CACHE_COHERENCY like vdpa & usnic do before
allowing an IOMMU backed VFIO device to be created.

Reviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
Acked-by: default avatarAlex Williamson <alex.williamson@redhat.com>
Acked-by: default avatarRobin Murphy <robin.murphy@arm.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/4-v3-2cf356649677+a32-intel_no_snoop_jgg@nvidia.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent f78dc1da

drivers/vfio/vfio.c

+7 −0
Original line number Diff line number Diff line
@@ -815,6 +815,13 @@ static int __vfio_register_dev(struct vfio_device *device, 


int vfio_register_group_dev(struct vfio_device *device)

{

	/*

	 * VFIO always sets IOMMU_CACHE because we offer no way for userspace to

	 * restore cache coherency.

	 */

	if (!iommu_capable(device->dev->bus, IOMMU_CAP_CACHE_COHERENCY))

		return -EINVAL;



	return __vfio_register_dev(device,

		vfio_group_find_or_alloc(device->dev));

}