Commit e88ccf09 authored by Tomi Valkeinen's avatar Tomi Valkeinen Committed by Mauro Carvalho Chehab
Browse files

media: i2c: max9286: fix access to unallocated memory 



The asd allocated with v4l2_async_notifier_add_fwnode_subdev() must be
of size max9286_asd, otherwise access to max9286_asd->source will go to
unallocated memory.

Fixes: 86d37bf3 ("media: i2c: max9286: Allocate v4l2_async_subdev dynamically")
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: stable@vger.kernel.org # v5.10+
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Tested-by: default avatarKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent c432147c

drivers/media/i2c/max9286.c

+1 −1
Original line number Diff line number Diff line
@@ -580,7 +580,7 @@ static int max9286_v4l2_notifier_register(struct max9286_priv *priv) 


		asd = v4l2_async_notifier_add_fwnode_subdev(&priv->notifier,

							    source->fwnode,

							    sizeof(*asd));

							    sizeof(struct max9286_asd));

		if (IS_ERR(asd)) {

			dev_err(dev, "Failed to add subdev for source %u: %ld",

				i, PTR_ERR(asd));