Commit e8865537 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva
Browse files

fcntl: Fix unreachable code in do_fcntl() 



Fix the following warning:

fs/fcntl.c:373:3: warning: fallthrough annotation in unreachable code [-Wimplicit-fallthrough]
                   fallthrough;
                   ^
   include/linux/compiler_attributes.h:210:41: note: expanded from macro 'fallthrough'
   # define fallthrough                    __attribute__((__fallthrough__))

by placing the fallthrough; statement inside ifdeffery.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
parent 1adee589

fs/fcntl.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -369,8 +369,8 @@ static long do_fcntl(int fd, unsigned int cmd, unsigned long arg, 
	/* 32-bit arches must use fcntl64() */

	/* 32-bit arches must use fcntl64() */

	case F_OFD_SETLK:

	case F_OFD_SETLK:

	case F_OFD_SETLKW:

	case F_OFD_SETLKW:

#endif

		fallthrough;

		fallthrough;

#endif

	case F_SETLK:

	case F_SETLK:

	case F_SETLKW:

	case F_SETLKW:

		if (copy_from_user(&flock, argp, sizeof(flock)))

		if (copy_from_user(&flock, argp, sizeof(flock)))