Commit e849145e authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by Greg Kroah-Hartman
Browse files

serial: ar933x: Fill in rs485_supported 



Add information on supported serial_rs485 features.

In the case where RTS is lacking, RS485 cannot be enabled so provide
zero rs485_supported for that case. Perhaps it would make sense to not
provide rs485_config() at all in that case but such a change would have
userspace visible impact/change in behavior so this patch does not
attempt it.

Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20220606100433.13793-14-ilpo.jarvinen@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ebe2cf73

drivers/tty/serial/ar933x_uart.c

+7 −0
Original line number Diff line number Diff line
@@ -702,6 +702,11 @@ static struct uart_driver ar933x_uart_driver = { 
	.cons		= NULL, /* filled in runtime */

};



static const struct serial_rs485 ar933x_no_rs485 = {};

static const struct serial_rs485 ar933x_rs485_supported = {

	.flags = SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND | SER_RS485_RTS_AFTER_SEND,

};



static int ar933x_uart_probe(struct platform_device *pdev)

{

	struct ar933x_uart_port *up;
@@ -773,6 +778,7 @@ static int ar933x_uart_probe(struct platform_device *pdev) 
	port->fifosize = AR933X_UART_FIFO_SIZE;

	port->ops = &ar933x_uart_ops;

	port->rs485_config = ar933x_config_rs485;

	port->rs485_supported = &ar933x_rs485_supported;



	baud = ar933x_uart_get_baud(port->uartclk, AR933X_UART_MAX_SCALE, 1);

	up->min_baud = max_t(unsigned int, baud, AR933X_UART_MIN_BAUD);
@@ -796,6 +802,7 @@ static int ar933x_uart_probe(struct platform_device *pdev) 
	    !up->rts_gpiod) {

		dev_err(&pdev->dev, "lacking rts-gpio, disabling RS485\n");

		port->rs485.flags &= ~SER_RS485_ENABLED;

		port->rs485_supported = &ar933x_no_rs485;

	}



#ifdef CONFIG_SERIAL_AR933X_CONSOLE