Commit e7e7104e authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

net: ethernet: mtk_eth_soc: out of bounds read in mtk_hwlro_get_fdir_entry() 



The "fsp->location" variable comes from user via ethtool_get_rxnfc().
Check that it is valid to prevent an out of bounds read.

Fixes: 7aab747e ("net: ethernet: mediatek: add ethtool functions to configure RX flows of HW LRO")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a54ce370

drivers/net/ethernet/mediatek/mtk_eth_soc.c

+3 −0
Original line number Diff line number Diff line
@@ -2212,6 +2212,9 @@ static int mtk_hwlro_get_fdir_entry(struct net_device *dev, 
	struct ethtool_rx_flow_spec *fsp =

		(struct ethtool_rx_flow_spec *)&cmd->fs;



	if (fsp->location >= ARRAY_SIZE(mac->hwlro_ip))

		return -EINVAL;



	/* only tcp dst ipv4 is meaningful, others are meaningless */

	fsp->flow_type = TCP_V4_FLOW;

	fsp->h_u.tcp_ip4_spec.ip4dst = ntohl(mac->hwlro_ip[fsp->location]);