Commit e7d966f9 authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by David S. Miller
Browse files

sh_eth: sh_eth_close() always returns 0 



sh_eth_close() always returns 0, hence the check in sh_eth_wol_restore()
is pointless (however we cannot change the prototype of sh_eth_close() as
it implements the driver's ndo_stop() method).

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent be94a51f

drivers/net/ethernet/renesas/sh_eth.c

+1 −3
Original line number Diff line number Diff line
@@ -3444,9 +3444,7 @@ static int sh_eth_wol_restore(struct net_device *ndev) 
	 * both be reset and all registers restored. This is what

	 * happens during suspend and resume without WoL enabled.

	 */

	ret = sh_eth_close(ndev);

	if (ret < 0)

		return ret;

	sh_eth_close(ndev);

	ret = sh_eth_open(ndev);

	if (ret < 0)

		return ret;