Commit e7d66cf7 authored by Jeremy Szu's avatar Jeremy Szu Committed by Takashi Iwai
Browse files

ALSA: hda/realtek: fix mute/micmute LEDs for HP 440 G8 



The HP EliteBook 840 G8 Notebook PC is using ALC236 codec which is
using 0x02 to control mute LED and 0x01 to control micmute LED.
Therefore, add a quirk to make it works.

Signed-off-by: default avatarJeremy Szu <jeremy.szu@canonical.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210316074626.79895-1-jeremy.szu@canonical.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent ca688339

sound/pci/hda/patch_realtek.c

+12 −0
Original line number Diff line number Diff line
@@ -4225,6 +4225,12 @@ static void alc_fixup_hp_gpio_led(struct hda_codec *codec, 
	}

}



static void alc236_fixup_hp_gpio_led(struct hda_codec *codec,

				const struct hda_fixup *fix, int action)

{

	alc_fixup_hp_gpio_led(codec, action, 0x02, 0x01);

}



static void alc269_fixup_hp_gpio_led(struct hda_codec *codec,

				const struct hda_fixup *fix, int action)

{
@@ -6381,6 +6387,7 @@ enum { 
	ALC294_FIXUP_ASUS_GX502_VERBS,

	ALC285_FIXUP_HP_GPIO_LED,

	ALC285_FIXUP_HP_MUTE_LED,

	ALC236_FIXUP_HP_GPIO_LED,

	ALC236_FIXUP_HP_MUTE_LED,

	ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET,

	ALC295_FIXUP_ASUS_MIC_NO_PRESENCE,
@@ -7616,6 +7623,10 @@ static const struct hda_fixup alc269_fixups[] = { 
		.type = HDA_FIXUP_FUNC,

		.v.func = alc285_fixup_hp_mute_led,

	},

	[ALC236_FIXUP_HP_GPIO_LED] = {

		.type = HDA_FIXUP_FUNC,

		.v.func = alc236_fixup_hp_gpio_led,

	},

	[ALC236_FIXUP_HP_MUTE_LED] = {

		.type = HDA_FIXUP_FUNC,

		.v.func = alc236_fixup_hp_mute_led,
@@ -8045,6 +8056,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { 
	SND_PCI_QUIRK(0x103c, 0x8783, "HP ZBook Fury 15 G7 Mobile Workstation",

		      ALC285_FIXUP_HP_GPIO_AMP_INIT),

	SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),

	SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),

	SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),

	SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),

	SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP),