Commit e7bcc145 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Kalle Valo
Browse files

ath11k: Fix an error handling path 



If 'kzalloc' fails, we must return an error code.

While at it, remove a useless initialization of 'err' which could hide the
issue.

Fixes: d5c65159 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201122173943.1366167-1-christophe.jaillet@wanadoo.fr
parent d35d1375

drivers/net/wireless/ath/ath11k/qmi.c

+4 −2
Original line number Diff line number Diff line
@@ -1591,15 +1591,17 @@ static int ath11k_qmi_fw_ind_register_send(struct ath11k_base *ab) 
	struct qmi_wlanfw_ind_register_resp_msg_v01 *resp;

	struct qmi_handle *handle = &ab->qmi.handle;

	struct qmi_txn txn;

	int ret = 0;

	int ret;



	req = kzalloc(sizeof(*req), GFP_KERNEL);

	if (!req)

		return -ENOMEM;



	resp = kzalloc(sizeof(*resp), GFP_KERNEL);

	if (!resp)

	if (!resp) {

		ret = -ENOMEM;

		goto resp_out;

	}



	req->client_id_valid = 1;

	req->client_id = QMI_WLANFW_CLIENT_ID;