Commit e7afa79a authored by Wenchao Chen's avatar Wenchao Chen Committed by Ulf Hansson
Browse files

mmc: hsq: Fix data stomping during mmc recovery 



The block device uses multiple queues to access emmc. There will be up to 3
requests in the hsq of the host. The current code will check whether there
is a request doing recovery before entering the queue, but it will not check
whether there is a request when the lock is issued. The request is in recovery
mode. If there is a request in recovery, then a read and write request is
initiated at this time, and the conflict between the request and the recovery
request will cause the data to be trampled.

Signed-off-by: default avatarWenchao Chen <wenchao.chen@unisoc.com>
Fixes: 511ce378 ("mmc: Add MMC host software queue support")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20220916090506.10662-1-wenchao.chen666@gmail.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 3c665633

drivers/mmc/host/mmc_hsq.c

+1 −1
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ static void mmc_hsq_pump_requests(struct mmc_hsq *hsq) 
	spin_lock_irqsave(&hsq->lock, flags);



	/* Make sure we are not already running a request now */

	if (hsq->mrq) {

	if (hsq->mrq || hsq->recovery_halt) {

		spin_unlock_irqrestore(&hsq->lock, flags);

		return;

	}