Commit e7a97528 authored by Dan Carpenter's avatar Dan Carpenter Committed by Miquel Raynal
Browse files

mtd: rawnand: fsmc: Fix error code in fsmc_nand_probe() 



If dma_request_channel() fails then the probe fails and it should
return a negative error code, but currently it returns success.

fixes: 4774fb0a ("mtd: nand/fsmc: Add DMA support")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/YCqaOZ83OvPOzLwh@mwanda
parent 469b9924

drivers/mtd/nand/raw/fsmc_nand.c

+2 −0
Original line number Diff line number Diff line
@@ -1077,11 +1077,13 @@ static int __init fsmc_nand_probe(struct platform_device *pdev) 
		host->read_dma_chan = dma_request_channel(mask, filter, NULL);

		if (!host->read_dma_chan) {

			dev_err(&pdev->dev, "Unable to get read dma channel\n");

			ret = -ENODEV;

			goto disable_clk;

		}

		host->write_dma_chan = dma_request_channel(mask, filter, NULL);

		if (!host->write_dma_chan) {

			dev_err(&pdev->dev, "Unable to get write dma channel\n");

			ret = -ENODEV;

			goto release_dma_read_chan;

		}

	}