Commit e79cf889 authored by Jan Kara's avatar Jan Kara Committed by Jens Axboe
Browse files

bfq: Remove superfluous conversion from RQ_BIC() 



We store struct bfq_io_cq pointer in rq->elv.priv[0] in bfq_init_rq().
Thus a call to icq_to_bic() in RQ_BIC() is wrong. Luckily it does no
harm currently because struct io_iq is the first one in struct
bfq_io_cq.

Signed-off-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220519105235.31397-3-jack@suse.cz


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent c5ac56bb

block/bfq-iosched.c

+1 −1
Original line number Diff line number Diff line
@@ -374,7 +374,7 @@ static const unsigned long bfq_activation_stable_merging = 600; 
 */

static const unsigned long bfq_late_stable_merging = 600;



#define RQ_BIC(rq)		icq_to_bic((rq)->elv.priv[0])

#define RQ_BIC(rq)		((struct bfq_io_cq *)((rq)->elv.priv[0]))

#define RQ_BFQQ(rq)		((rq)->elv.priv[1])



struct bfq_queue *bic_to_bfqq(struct bfq_io_cq *bic, bool is_sync)