Commit e7968161 authored by Zhipeng Lu's avatar Zhipeng Lu Committed by Liu Shixin
Browse files

media: atomisp: ssh_css: Fix a null-pointer dereference in load_video_binaries 

stable inclusion
from stable-v5.10.219
commit 4b68b861b514a5c09220d622ac3784c0ebac6c80
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IA6SGC
CVE: CVE-2024-38547

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=4b68b861b514a5c09220d622ac3784c0ebac6c80

--------------------------------

[ Upstream commit 3b621e9e9e148c0928ab109ac3d4b81487469acb ]

The allocation failure of mycs->yuv_scaler_binary in load_video_binaries()
is followed with a dereference of mycs->yuv_scaler_binary after the
following call chain:

sh_css_pipe_load_binaries()
  |-> load_video_binaries(mycs->yuv_scaler_binary == NULL)
  |
  |-> sh_css_pipe_unload_binaries()
        |-> unload_video_binaries()

In unload_video_binaries(), it calls to ia_css_binary_unload with argument
&pipe->pipe_settings.video.yuv_scaler_binary[i], which refers to the
same memory slot as mycs->yuv_scaler_binary. Thus, a null-pointer
dereference is triggered.

Link: https://lore.kernel.org/r/20240118151303.3828292-1-alexious@zju.edu.cn



Fixes: a49d2536 ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: default avatarZhipeng Lu <alexious@zju.edu.cn>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarLiu Shixin <liushixin2@huawei.com>
parent 3340cc60

drivers/staging/media/atomisp/pci/sh_css.c

+1 −0
Original line number Diff line number Diff line
@@ -5477,6 +5477,7 @@ static int load_video_binaries(struct ia_css_pipe *pipe) 
		mycs->yuv_scaler_binary = kzalloc(cas_scaler_descr.num_stage *

						  sizeof(struct ia_css_binary), GFP_KERNEL);

		if (!mycs->yuv_scaler_binary) {

			mycs->num_yuv_scaler = 0;

			err = -ENOMEM;

			return err;

		}