Commit e75858b9 authored by Miaohe Lin's avatar Miaohe Lin Committed by Andrew Morton
Browse files

mm/huge_memory: use helper macro IS_ERR_OR_NULL in split_huge_pages_pid 

Use helper macro IS_ERR_OR_NULL to check the validity of page to simplify
the code. Minor readability improvement.

Link: https://lkml.kernel.org/r/20220704132201.14611-17-linmiaohe@huawei.com


Signed-off-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
Reviewed-by: default avatarMuchun Song <songmuchun@bytedance.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Yang Shi <shy828301@gmail.com>
Cc: Zach O'Keefe <zokeefe@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent cea33328

mm/huge_memory.c

+1 −3
Original line number Diff line number Diff line
@@ -2958,9 +2958,7 @@ static int split_huge_pages_pid(int pid, unsigned long vaddr_start, 
		/* FOLL_DUMP to ignore special (like zero) pages */

		page = follow_page(vma, addr, FOLL_GET | FOLL_DUMP);



		if (IS_ERR(page))

			continue;

		if (!page || is_zone_device_page(page))

		if (IS_ERR_OR_NULL(page) || is_zone_device_page(page))

			continue;



		if (!is_transparent_hugepage(page))