Commit e714fa93 authored by Rikard Falkeborn's avatar Rikard Falkeborn Committed by Takashi Iwai
Browse files

ALSA: aloop: Constify ops structs 



The only usage of the ops field in the loopback_cable struct is to call
its members, the field it self is never changed. Make it a pointer to
const. This allows us to constify two static loopback_ops structs to
allow the compiler to put them in read-only memory.

Signed-off-by: default avatarRikard Falkeborn <rikard.falkeborn@gmail.com>
Link: https://lore.kernel.org/r/20201120231046.76758-1-rikard.falkeborn@gmail.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 45bbe6c9

sound/drivers/aloop.c

+3 −3
Original line number Diff line number Diff line
@@ -105,7 +105,7 @@ struct loopback_cable { 
	unsigned int running;

	unsigned int pause;

	/* timer specific */

	struct loopback_ops *ops;

	const struct loopback_ops *ops;

	/* If sound timer is used */

	struct {

		int stream;
@@ -1021,7 +1021,7 @@ static int loopback_jiffies_timer_open(struct loopback_pcm *dpcm) 
	return 0;

}



static struct loopback_ops loopback_jiffies_timer_ops = {

static const struct loopback_ops loopback_jiffies_timer_ops = {

	.open = loopback_jiffies_timer_open,

	.start = loopback_jiffies_timer_start,

	.stop = loopback_jiffies_timer_stop,
@@ -1172,7 +1172,7 @@ static int loopback_snd_timer_open(struct loopback_pcm *dpcm) 
/* stop_sync() is not required for sound timer because it does not need to be

 * restarted in loopback_prepare() on Xrun recovery

 */

static struct loopback_ops loopback_snd_timer_ops = {

static const struct loopback_ops loopback_snd_timer_ops = {

	.open = loopback_snd_timer_open,

	.start = loopback_snd_timer_start,

	.stop = loopback_snd_timer_stop,