Commit e6976148 authored by Tao Chen's avatar Tao Chen Committed by Jakub Kicinski
Browse files

netlink: Fix potential skb memleak in netlink_ack 



Fix coverity issue 'Resource leak'.

We should clean the skb resource if nlmsg_put/append failed.

Fixes: 738136a0 ("netlink: split up copies in the ack construction")
Signed-off-by: default avatarTao Chen <chentao.kernel@linux.alibaba.com>
Link: https://lore.kernel.org/r/bff442d62c87de6299817fe1897cc5a5694ba9cc.1667638204.git.chentao.kernel@linux.alibaba.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 14ef5c39

net/netlink/af_netlink.c

+3 −1
Original line number Diff line number Diff line
@@ -2500,7 +2500,7 @@ void netlink_ack(struct sk_buff *in_skb, struct nlmsghdr *nlh, int err, 


	skb = nlmsg_new(payload + tlvlen, GFP_KERNEL);

	if (!skb)

		goto err_bad_put;

		goto err_skb;



	rep = nlmsg_put(skb, NETLINK_CB(in_skb).portid, nlh->nlmsg_seq,

			NLMSG_ERROR, sizeof(*errmsg), flags);
@@ -2528,6 +2528,8 @@ void netlink_ack(struct sk_buff *in_skb, struct nlmsghdr *nlh, int err, 
	return;



err_bad_put:

	nlmsg_free(skb);

err_skb:

	NETLINK_CB(in_skb).sk->sk_err = ENOBUFS;

	sk_error_report(NETLINK_CB(in_skb).sk);

}