Commit e684000b authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller
Browse files

net: dsa: bcm_sf2: Fix driver removal 



With the DSA core doing the call to dsa_port_disable() we do not need to
do that within the driver itself. This could cause an use after free
since past dsa_unregister_switch() we should not be accessing any
dsa_switch internal structures.

Fixes: 0394a63a ("net: dsa: enable and disable all ports")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Reviewed-by: default avatarVivien Didelot <vivien.didelot@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 59eb87cb

drivers/net/dsa/bcm_sf2.c

+2 −2
Original line number Diff line number Diff line
@@ -1215,10 +1215,10 @@ static int bcm_sf2_sw_remove(struct platform_device *pdev) 
	struct bcm_sf2_priv *priv = platform_get_drvdata(pdev);



	priv->wol_ports_mask = 0;

	/* Disable interrupts */

	bcm_sf2_intr_disable(priv);

	dsa_unregister_switch(priv->dev->ds);

	bcm_sf2_cfp_exit(priv->dev->ds);

	/* Disable all ports and interrupts */

	bcm_sf2_sw_suspend(priv->dev->ds);

	bcm_sf2_mdio_unregister(priv);



	return 0;