Commit e67dfb8d authored by Amit Cohen's avatar Amit Cohen Committed by David S. Miller
Browse files

selftests: Clean forgotten resources as part of cleanup() 



Several tests do not set some ports down as part of their cleanup(),
resulting in IPv6 link-local addresses and associated routes not being
deleted.

These leaks were found using a BPF tool that monitors ASIC resources.

Solve this by setting the ports down at the end of the tests.

Signed-off-by: default avatarAmit Cohen <amcohen@nvidia.com>
Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 00190c2b

tools/testing/selftests/drivers/net/mlxsw/devlink_trap_l3_drops.sh

+3 −0
Original line number Diff line number Diff line
@@ -109,6 +109,9 @@ router_destroy() 
	__addr_add_del $rp1 del 192.0.2.2/24 2001:db8:1::2/64



	tc qdisc del dev $rp2 clsact



	ip link set dev $rp2 down

	ip link set dev $rp1 down

}



setup_prepare()

tools/testing/selftests/drivers/net/mlxsw/devlink_trap_l3_exceptions.sh

+3 −0
Original line number Diff line number Diff line
@@ -111,6 +111,9 @@ router_destroy() 
	__addr_add_del $rp1 del 192.0.2.2/24 2001:db8:1::2/64



	tc qdisc del dev $rp2 clsact



	ip link set dev $rp2 down

	ip link set dev $rp1 down

}



setup_prepare()

tools/testing/selftests/drivers/net/mlxsw/qos_dscp_bridge.sh

+2 −0
Original line number Diff line number Diff line
@@ -93,7 +93,9 @@ switch_destroy() 
	lldptool -T -i $swp1 -V APP -d $(dscp_map 10) >/dev/null

	lldpad_app_wait_del



	ip link set dev $swp2 down

	ip link set dev $swp2 nomaster

	ip link set dev $swp1 down

	ip link set dev $swp1 nomaster

	ip link del dev br1

}

tools/testing/selftests/net/forwarding/pedit_dsfield.sh

+2 −0
Original line number Diff line number Diff line
@@ -75,7 +75,9 @@ switch_destroy() 
	tc qdisc del dev $swp2 clsact

	tc qdisc del dev $swp1 clsact



	ip link set dev $swp2 down

	ip link set dev $swp2 nomaster

	ip link set dev $swp1 down

	ip link set dev $swp1 nomaster

	ip link del dev br1

}

tools/testing/selftests/net/forwarding/pedit_l4port.sh

+2 −0
Original line number Diff line number Diff line
@@ -71,7 +71,9 @@ switch_destroy() 
	tc qdisc del dev $swp2 clsact

	tc qdisc del dev $swp1 clsact



	ip link set dev $swp2 down

	ip link set dev $swp2 nomaster

	ip link set dev $swp1 down

	ip link set dev $swp1 nomaster

	ip link del dev br1

}